feat(url): implement URL.searchParams property#1803
Closed
David Anderson (akapug) wants to merge 1 commit intomainfrom
Closed
feat(url): implement URL.searchParams property#1803David Anderson (akapug) wants to merge 1 commit intomainfrom
David Anderson (akapug) wants to merge 1 commit intomainfrom
Conversation
Implements the searchParams property on URL objects by parsing the
query string into a URLSearchParams instance.
Previously, accessing url.searchParams threw NotImplementedError.
Now it returns a properly populated URLSearchParams object that
supports get(), has(), entries(), forEach(), etc.
Example:
const url = new URL('http://example.com?foo=bar&baz=qux');
url.searchParams.get('foo'); // 'bar'
url.searchParams.has('baz'); // true
Why this matters:
Server-side code using the fetch handler pattern needs to parse
query parameters from incoming requests. Without searchParams.get(),
developers must manually parse the query string, which is error-prone
and inconsistent with the URL spec.
Dario Valdespino (darvld)
approved these changes
Nov 27, 2025
Member
Dario Valdespino (darvld)
left a comment
There was a problem hiding this comment.
CI failures are unrelated, changes are good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
searchParamsproperty on URL objects by parsing the query string into aURLSearchParamsinstance.Previously, accessing
url.searchParamsthrewNotImplementedError. Now it returns a properly populatedURLSearchParamsobject.Example
Why This Matters
Server-side code using the fetch handler pattern needs to parse query parameters from incoming requests:
Without
searchParams.get(), developers must manually parse the query string, which is error-prone and inconsistent with the URL spec.Changes
URLIntrinsic.kt: ImplementcomputeSearchParams()to parse query string intoURLSearchParamsTesting
Tested locally with Elide beta11-rc3:
cc Dario Valdespino (@darvld) - this is a simple 6-line fix for a TODO that was blocking server-side URL parsing.